Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_depth parameter to ModelSummary #8062

Merged
merged 42 commits into from
Jul 1, 2021
Merged

Add max_depth parameter to ModelSummary #8062

merged 42 commits into from
Jul 1, 2021

Conversation

ManuelPalermo
Copy link
Contributor

@ManuelPalermo ManuelPalermo commented Jun 21, 2021

What does this PR do?

Adds feature discussed in #8047 (comment)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@pep8speaks
Copy link

pep8speaks commented Jun 21, 2021

Hello @ManuelPalermo! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-01 00:27:05 UTC

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #8062 (a479cfa) into master (1afc1ca) will decrease coverage by 5%.
The diff coverage is 94%.

@@           Coverage Diff           @@
##           master   #8062    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         212     212            
  Lines       13581   13595    +14     
=======================================
- Hits        12624   11954   -670     
- Misses        957    1641   +684     

tests/core/test_memory.py Outdated Show resolved Hide resolved
@Borda Borda added design Includes a design discussion feature Is an improvement or enhancement labels Jun 21, 2021
@ManuelPalermo ManuelPalermo marked this pull request as draft June 21, 2021 16:11
@ManuelPalermo ManuelPalermo marked this pull request as ready for review June 22, 2021 11:25
pytorch_lightning/core/lightning.py Show resolved Hide resolved
pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
pytorch_lightning/core/memory.py Outdated Show resolved Hide resolved
pytorch_lightning/core/memory.py Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Jun 29, 2021
@ManuelPalermo ManuelPalermo requested a review from carmocca June 29, 2021 16:34
@carmocca carmocca added the ready PRs ready to be merged label Jun 29, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 29, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't work yet.

Trainer(weights_summary="full"|"top") does not display anything on this branch.

need to investigate.

@awaelchli awaelchli removed the ready PRs ready to be merged label Jun 30, 2021
@ManuelPalermo ManuelPalermo requested a review from awaelchli June 30, 2021 22:03
@mergify mergify bot removed the has conflicts label Jun 30, 2021
@carmocca carmocca merged commit 36b893c into Lightning-AI:master Jul 1, 2021
@mergify mergify bot added the ready PRs ready to be merged label Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants