-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XLA Profiler integration #8014
XLA Profiler integration #8014
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8014 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 211 212 +1
Lines 13440 13491 +51
=======================================
- Hits 12474 11854 -620
- Misses 966 1637 +671 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you update with master it should get the fix for the failing docs build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov won't reach these lines due to the skipped test? not sure, but you may have to exclude it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😃 some issues with the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
What does this PR do?
Could approach the XLA Profiler in two ways:
Would be so much more fun with Programmatic Capture (But with the current XLA API, finding issues with
xp.trace
). Not really convinced to hack it around. (Second iteration)Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃