-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning_cache.deprecation
and set warning stacklevel [1/2]
#8005
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8005 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 207 207
Lines 13374 13494 +120
=======================================
- Hits 12246 11722 -524
- Misses 1128 1772 +644 |
@kaushikb11 I think #8002 should already resolve this since there |
Not really, but I added
Yes, but let's fix this separately here. Pushing some changes |
warning_cache.deprecation
and set warning stacklevel
warning_cache.deprecation
and set warning stacklevelwarning_cache.deprecation
and set warning stacklevel [1/2]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you find the solution independently? nice coincidence, @carmocca and me kinda found the same peculiar warning behavior
Not a coincidence. I updated the PR 😆 |
Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Carlos Mocholi <[email protected]>
What does this PR do?
Ran an example in Lightning Flash. Was bombarded with this warning.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃