-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add predict hook test #7973
Merged
Merged
Add predict hook test #7973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
commented
Jun 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #7973 +/- ##
======================================
- Coverage 92% 91% -0%
======================================
Files 203 203
Lines 13137 13157 +20
======================================
- Hits 12023 12005 -18
- Misses 1114 1152 +38 |
kaushikb11
reviewed
Jun 14, 2021
awaelchli
approved these changes
Jun 15, 2021
Borda
approved these changes
Jun 15, 2021
tchaton
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
HookedCallback
to append the called hooks. This way we can test the order between theLightningModule
andCallback
. This also has the benefit that inconsistencies are easier to notice.A small fix is included to call the
stage
argument in the Callbacksetup/teardown
by keyword argument. The hook was called by keyword for theLightningModule
but positionally for theCallback
.Related to the Lightning hooks review: #7740
Notes
Added
TODO
s for all the inconsistencies that surfaced. Do not plan to fix them here.Before submitting
PR review