-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seed all workers when using DDP #7942
Merged
tchaton
merged 8 commits into
Lightning-AI:master
from
groke-technologies:bugfix/seed-ddp-workers
Jun 14, 2021
Merged
Seed all workers when using DDP #7942
tchaton
merged 8 commits into
Lightning-AI:master
from
groke-technologies:bugfix/seed-ddp-workers
Jun 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senarvi
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
June 11, 2021 12:48
@awaelchli feel free to suggest better log messages. |
carmocca
added
bug
Something isn't working
distributed
Generic distributed-related topic
labels
Jun 11, 2021
carmocca
reviewed
Jun 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #7942 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 203 203
Lines 13129 13131 +2
=======================================
- Hits 12017 11399 -618
- Misses 1112 1732 +620 |
Co-authored-by: Carlos Mocholí <[email protected]>
…es/pytorch-lightning into bugfix/seed-ddp-workers
justusschock
approved these changes
Jun 14, 2021
awaelchli
approved these changes
Jun 14, 2021
tchaton
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT. Great catch !
Closed
carmocca
added a commit
that referenced
this pull request
Jun 15, 2021
* Seed all workers when using DDP * Fix to dataloader seeding * Make argument name explicit Co-authored-by: Carlos Mocholí <[email protected]> * Use f-strings when logging * Removed a redundant log message Co-authored-by: Carlos Mocholí <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Seed all workers when using DDP * Fix to dataloader seeding * Make argument name explicit Co-authored-by: Carlos Mocholí <[email protected]> * Use f-strings when logging * Removed a redundant log message Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
distributed
Generic distributed-related topic
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When seed_everything(workers=True) is called, it will set the environment variable PL_SEED_WORKERS=1. Consequently Trainer will set the worker_init_fn for dataloaders to
pl_worker_init_function
. However, this did not work with plugins that callreset_seed()
, since that function callsseed_everything()
with the default argumentworkers=False
. This bug fix changesseed_everything()
so that it will read thePL_SEED_WORKERS
environment variable and pass the correct value forworkers
.Fixes #7937
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃