-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dataclass support on apply_to_collection #7935
add dataclass support on apply_to_collection #7935
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7935 +/- ##
=======================================
- Coverage 93% 87% -6%
=======================================
Files 200 203 +3
Lines 12797 13129 +332
=======================================
- Hits 11852 11398 -454
- Misses 945 1731 +786 |
…lass' into feature/apply-func-support-dataclass # Conflicts: # tests/utilities/test_apply_func.py
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice addition
dataclasses reduce boilerplate code, so does Lightning. We should make best friends! <3
…lass' into feature/apply-func-support-dataclass # Conflicts: # tests/utilities/test_apply_func.py
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Nice addition.
…lass' into feature/apply-func-support-dataclass
Co-authored-by: Jirka Borovec <[email protected]>
What does this PR do?
issue:#7878
Add dataclass support on apply_to_collection, not only on move_batch_to_device
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃