Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dataclass support on apply_to_collection #7935

Merged

Conversation

dalek-who
Copy link
Contributor

@dalek-who dalek-who commented Jun 11, 2021

What does this PR do?

issue:#7878
Add dataclass support on apply_to_collection, not only on move_batch_to_device

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #7935 (632ebdb) into master (839019a) will decrease coverage by 6%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7935    +/-   ##
=======================================
- Coverage      93%     87%    -6%     
=======================================
  Files         200     203     +3     
  Lines       12797   13129   +332     
=======================================
- Hits        11852   11398   -454     
- Misses        945    1731   +786     

dalek-who and others added 4 commits June 11, 2021 14:50
@dalek-who dalek-who marked this pull request as draft June 11, 2021 07:11
@dalek-who dalek-who marked this pull request as ready for review June 11, 2021 07:21
@carmocca carmocca added the feature Is an improvement or enhancement label Jun 11, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 11, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice addition
dataclasses reduce boilerplate code, so does Lightning. We should make best friends! <3

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Nice addition.

@tchaton tchaton enabled auto-merge (squash) June 11, 2021 13:37
@tchaton tchaton disabled auto-merge June 11, 2021 13:38
@tchaton tchaton enabled auto-merge (squash) June 11, 2021 13:38
@tchaton tchaton added the ready PRs ready to be merged label Jun 11, 2021
@carmocca carmocca disabled auto-merge June 11, 2021 16:08
@carmocca carmocca enabled auto-merge (squash) June 12, 2021 11:18
@carmocca carmocca merged commit 59d0c65 into Lightning-AI:master Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants