-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightningCLI support for argument links applied on instantiation #7895
LightningCLI support for argument links applied on instantiation #7895
Conversation
Hello @mauvilsa! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-09 19:33:48 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7895 +/- ##
========================================
- Coverage 91% 84% -7%
========================================
Files 204 204
Lines 13630 13657 +27
========================================
- Hits 12414 11415 -999
- Misses 1216 2242 +1026 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still draft? What's missing?
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smart!
What does this PR do?
From discussions mostly in slack it became clear that there are common cases in which parameters that are only available after instantiating the data module class are needed to instantiate the model. To achieve the user had to subclass LightningCLI in a non-trivial way. With this PR these cases can be implemented in a much simpler way. The concept of argument linking is extended so that they can be applied on instantiation. It use is explained in the change of lightning_cli.rst.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃