Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs overwriting issue for remote fs #7889

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Jun 9, 2021

What does this PR do?

Related Issue: fsspec/gcsfs#312

There's an inconsistency while using fsspec's isdir for some remote fs.

Along the lines of The folder name will be an exact match and assumed to be a file on the first invocation.
This is causing our logger to have issues with remote filesystems, by overwriting the existing logs, rather than creating a new dir.

-> if not self._fs.isdir(root_dir):
(Pdb) self._fs.isdir(root_dir)
False
(Pdb) self._fs.isdir(root_dir)
True

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #7889 (5f8e6e6) into master (b214442) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7889    +/-   ##
=======================================
- Coverage      91%     86%    -5%     
=======================================
  Files         204     204            
  Lines       13630   13632     +2     
=======================================
- Hits        12414   11790   -624     
- Misses       1216    1842   +626     

@kaushikb11 kaushikb11 marked this pull request as ready for review June 9, 2021 01:23
@kaushikb11 kaushikb11 self-assigned this Jun 9, 2021
@kaushikb11 kaushikb11 added bug Something isn't working priority: 0 High priority task labels Jun 9, 2021
@Borda Borda enabled auto-merge (squash) June 9, 2021 07:35
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@awaelchli
Copy link
Contributor

awaelchli commented Jun 9, 2021

Probably needs a changelog entry right?
I added the milestone

@awaelchli awaelchli added this to the v1.3.x milestone Jun 9, 2021
@Borda Borda merged commit 7f4ef6d into Lightning-AI:master Jun 9, 2021
@carmocca carmocca mentioned this pull request Jun 15, 2021
carmocca pushed a commit that referenced this pull request Jun 15, 2021
* Fix logs overwriting issue for remote fs

* Add test
lexierule pushed a commit that referenced this pull request Jun 17, 2021
* Fix logs overwriting issue for remote fs

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants