-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logs overwriting issue for remote fs #7889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7889 +/- ##
=======================================
- Coverage 91% 86% -5%
=======================================
Files 204 204
Lines 13630 13632 +2
=======================================
- Hits 12414 11790 -624
- Misses 1216 1842 +626 |
kaushikb11
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
June 9, 2021 01:23
ethanwharris
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
awaelchli
approved these changes
Jun 9, 2021
Probably needs a changelog entry right? |
justusschock
approved these changes
Jun 9, 2021
Closed
carmocca
pushed a commit
that referenced
this pull request
Jun 15, 2021
* Fix logs overwriting issue for remote fs * Add test
lexierule
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Fix logs overwriting issue for remote fs * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related Issue: fsspec/gcsfs#312
There's an inconsistency while using fsspec's
isdir
for some remote fs.Along the lines of
The folder name will be an exact match and assumed to be a file on the first invocation.
This is causing our logger to have issues with remote filesystems, by overwriting the existing logs, rather than creating a new dir.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃