Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use apply_to_collection in metrics_to_scalars #7888

Merged
merged 5 commits into from
Jun 8, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jun 8, 2021

What does this PR do?

Part of #7882

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the feature Is an improvement or enhancement label Jun 8, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 8, 2021
@carmocca carmocca self-assigned this Jun 8, 2021
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #7888 (5456561) into master (4f3af42) will decrease coverage by 0%.
The diff coverage is 100%.

❗ Current head 5456561 differs from pull request most recent head 784668b. Consider uploading reports for the commit 784668b to get more accurate results

@@          Coverage Diff           @@
##           master   #7888   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         202     202           
  Lines       13161   13159    -2     
======================================
- Hits        11566   11526   -40     
- Misses       1595    1633   +38     

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

pytorch_lightning/utilities/metrics.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@carmocca carmocca enabled auto-merge (squash) June 8, 2021 16:28
@carmocca carmocca added the ready PRs ready to be merged label Jun 8, 2021
@carmocca carmocca disabled auto-merge June 8, 2021 16:53
@lexierule lexierule merged commit b74f8ac into master Jun 8, 2021
@lexierule lexierule deleted the feat/metrics-to-scalar-apply-to-collection branch June 8, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants