Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the on_before_backward hook #7865

Merged
merged 148 commits into from
Jul 9, 2021
Merged

Add the on_before_backward hook #7865

merged 148 commits into from
Jul 9, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 7, 2021

What does this PR do?

This PR adds on_before_backward hook and passes only the loss.

Fixes #7789

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Jun 7, 2021
@tchaton tchaton added this to the v1.4 milestone Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #7865 (b47470b) into master (1ad1a89) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7865   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         214     214           
  Lines       13891   13900    +9     
======================================
- Hits        12816   12812    -4     
- Misses       1075    1088   +13     

@tchaton tchaton marked this pull request as ready for review June 7, 2021 11:48
@awaelchli
Copy link
Contributor

Is it not better to call on_before_backward in the training loop directly (instead of plugins) like we do for the on_after_backward? Or is there a blocker?

otherwise LGTM makes sense to include this hook

@mergify mergify bot added the has conflicts label Jul 8, 2021
@mergify mergify bot removed the has conflicts label Jul 8, 2021
@carmocca carmocca changed the title [feat] Add on_before_backward hook Add the on_before_backward hook Jul 8, 2021
@tchaton tchaton enabled auto-merge (squash) July 9, 2021 05:54
@tchaton tchaton merged commit 1c825a2 into master Jul 9, 2021
@tchaton tchaton deleted the before_backward_hook branch July 9, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add training step callback hook before .backward
7 participants