Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPU] Add hooks for IPU lifecycle 4/5 #7864

Merged
merged 2 commits into from
Jun 7, 2021
Merged

[IPU] Add hooks for IPU lifecycle 4/5 #7864

merged 2 commits into from
Jun 7, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Jun 7, 2021

What does this PR do?

Adds hooks to the accelerator to allow the IPU accelerator to onload/deload models at the end of each stage.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the 3rd party Related to a 3rd-party label Jun 7, 2021
@SeanNaren SeanNaren added this to the v1.4 milestone Jun 7, 2021
@SeanNaren SeanNaren self-assigned this Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #7864 (1f846a3) into master (ea71cf4) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7864   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         202     202           
  Lines       13096   13121   +25     
======================================
+ Hits        11515   11527   +12     
- Misses       1581    1594   +13     

@awaelchli awaelchli added design Includes a design discussion feature Is an improvement or enhancement labels Jun 7, 2021
@SeanNaren SeanNaren requested review from Borda and carmocca as code owners June 7, 2021 11:25
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaushikb11 kaushikb11 enabled auto-merge (squash) June 7, 2021 11:39
@kaushikb11 kaushikb11 merged commit 41be61c into master Jun 7, 2021
@kaushikb11 kaushikb11 deleted the feat/acc_4n branch June 7, 2021 12:06
Borda pushed a commit that referenced this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party design Includes a design discussion feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants