-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move amp checkpoint state management to precision plugin #7831
Conversation
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-06-07 07:08:27 UTC |
27730ac
to
5b443f2
Compare
5b443f2
to
673dab9
Compare
Codecov Report
@@ Coverage Diff @@
## master #7831 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 202 202
Lines 13050 13053 +3
======================================
- Hits 12085 12049 -36
- Misses 965 1004 +39 |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a question: could we maybe group those args under a precision subdict so that we don't pollute the global checkpoint namespace?
would be great but then we would have to deal with backward compatibility too 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to update the CHANGELOG for this?
What does this PR do?
Part of #7652 (splitting down diff)
Makes checkpoint saving/loading logic agnostic to precision being used.
This is just a refactor, no changes to the current behavior are intended.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃