Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate manual optimization and supported features before running training #7788

Merged
merged 9 commits into from
Jun 3, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 1, 2021

What does this PR do?

Provides a better error message for unsupported features with manual optimization.

  • gradient clipping (cryptic error message)
  • gradient accumulation (would silently not work)

Fixes #7698

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the feature Is an improvement or enhancement label Jun 1, 2021
@awaelchli awaelchli added this to the v1.4 milestone Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #7788 (3640220) into master (0b6fd1d) will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7788    +/-   ##
=======================================
+ Coverage      88%     92%    +4%     
=======================================
  Files         199     199            
  Lines       12987   13016    +29     
=======================================
+ Hits        11412   12014   +602     
+ Misses       1575    1002   -573     

@awaelchli awaelchli marked this pull request as ready for review June 1, 2021 11:51
pytorch_lightning/trainer/configuration_validator.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/configuration_validator.py Outdated Show resolved Hide resolved
tests/trainer/test_config_validator.py Outdated Show resolved Hide resolved
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 1, 2021
@awaelchli awaelchli enabled auto-merge (squash) June 1, 2021 16:10
@awaelchli awaelchli merged commit 36770b2 into master Jun 3, 2021
@awaelchli awaelchli deleted the feature/manual-opt-verification branch June 3, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'param_groups'
4 participants