Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added save_config_filename init argument to LightningCLI #7741

Merged
merged 1 commit into from
May 28, 2021
Merged

Added save_config_filename init argument to LightningCLI #7741

merged 1 commit into from
May 28, 2021

Conversation

mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented May 27, 2021

What does this PR do?

Fixes #7679

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Sorry, something went wrong.

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #7741 (1be09d3) into master (9304c0d) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7741    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         199     199            
  Lines       12963   12965     +2     
=======================================
- Hits        11992   11375   -617     
- Misses        971    1590   +619     

@mauvilsa mauvilsa marked this pull request as ready for review May 27, 2021 17:41
@awaelchli awaelchli added argparse (removed) Related to argument parsing (argparse, Hydra, ...) feature Is an improvement or enhancement labels May 27, 2021
@awaelchli awaelchli added this to the v1.4 milestone May 27, 2021
@Borda Borda merged commit f6b5e3d into Lightning-AI:master May 28, 2021
@mauvilsa mauvilsa deleted the cli_init_save_config_filename branch May 28, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argparse (removed) Related to argument parsing (argparse, Hydra, ...) feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WandB logger and LightningCLI save_config_callback clashes
4 participants