-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve UserWarning message #7685
Merged
rohitgr7
merged 5 commits into
Lightning-AI:master
from
Lucklyric:fix/improve_userwarning_msg
May 25, 2021
Merged
fix: improve UserWarning message #7685
rohitgr7
merged 5 commits into
Lightning-AI:master
from
Lucklyric:fix/improve_userwarning_msg
May 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when both overfit and training dtaloader shuffling are enabled fixes issue: Lightning-AI#7656
Codecov Report
@@ Coverage Diff @@
## master #7685 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 199 199
Lines 12957 12957
=======================================
- Hits 11988 11368 -620
- Misses 969 1589 +620 |
ananthsub
reviewed
May 24, 2021
ananthsub
approved these changes
May 24, 2021
Co-authored-by: ananthsub <[email protected]>
awaelchli
approved these changes
May 24, 2021
carmocca
reviewed
May 24, 2021
carmocca
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve UserWarning message when both overfit and training dataloader shuffling are enabled
What does this PR do?
Fixes #7656
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃