Add __len__ method to IndexBatchSamplerWrapper
#7681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kaushikb11! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-26 15:35:05 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #7681 +/- ##
=======================================
- Coverage 93% 88% -5%
=======================================
Files 199 199
Lines 12960 12962 +2
=======================================
- Hits 11990 11373 -617
- Misses 970 1589 +619 |
kaushikb11
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
kaushikb11
changed the title
__len__ method to IndexBatchSampler__len__ method to IndexBatchSamplerWrapper
awaelchli
approved these changes
May 24, 2021
carmocca
reviewed
May 24, 2021
tests/models/test_tpu.py
Outdated
|
|
||
| @RunIf(tpu=True) | ||
| @pl_multi_process_test | ||
| def test_predict_tpu_multi_cores(tmpdir): |
There was a problem hiding this comment.
I think an unit test would be better suited for this PR
There was a problem hiding this comment.
What do you have in mind? Just check the len attribute for IndexBatchSamplerWrapper?
There was a problem hiding this comment.
Yeah, simple and effective 😜
tchaton
approved these changes
May 25, 2021
carmocca
approved these changes
May 26, 2021
Closed
tchaton
pushed a commit
that referenced
this pull request
Jun 1, 2021
tchaton
pushed a commit
that referenced
this pull request
Jun 1, 2021
Borda
pushed a commit
that referenced
this pull request
Jun 1, 2021
tchaton
pushed a commit
that referenced
this pull request
Jun 1, 2021
lexierule
pushed a commit
that referenced
this pull request
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7664
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃