-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dataloaders are not reset when tuning the model #7566
Fix dataloaders are not reset when tuning the model #7566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7566 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 196 198 +2
Lines 12835 12837 +2
=======================================
- Hits 11854 11291 -563
- Misses 981 1546 +565 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that fails in current master and is fixed by the changes in this PR?
4f8b5ab
to
d5c4c3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Good catch ! Just need the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the test that fails in current master myself. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed I'm not able to push changes to your fork's branch. I'm guessing you have disabled this:
Can you enable it? Alternatively, you can cherry-pick this commit d88b88c
Dear @carmocca , it seems the option is already enabled. NVM, I have cherry-picked your revision. Thank you so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Carlos Mocholi <[email protected]>
Co-authored-by: Carlos Mocholi <[email protected]>
What does this PR do?
Fixes #7562
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃