Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataloaders are not reset when tuning the model #7566

Merged
merged 5 commits into from
May 24, 2021

Conversation

Lucklyric
Copy link
Contributor

@Lucklyric Lucklyric commented May 16, 2021

What does this PR do?

Fixes #7562

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #7566 (92d8f31) into master (e126649) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7566    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         196     198     +2     
  Lines       12835   12837     +2     
=======================================
- Hits        11854   11291   -563     
- Misses        981    1546   +565     

@Lucklyric Lucklyric marked this pull request as ready for review May 16, 2021 06:58
@Lucklyric Lucklyric changed the title Fix dataloaders are not rest when tuning the model Fix dataloaders are not reset when tuning the model May 17, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that fails in current master and is fixed by the changes in this PR?

pytorch_lightning/trainer/training_loop.py Outdated Show resolved Hide resolved
pytorch_lightning/trainer/training_loop.py Outdated Show resolved Hide resolved
@carmocca carmocca added bug Something isn't working tuner labels May 18, 2021
@carmocca carmocca added this to the v1.3.x milestone May 18, 2021
@Lucklyric Lucklyric force-pushed the fix/dl_not_rest_when_tune branch from 4f8b5ab to d5c4c3f Compare May 18, 2021 18:59
@Lucklyric Lucklyric requested a review from SkafteNicki as a code owner May 18, 2021 18:59
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Good catch ! Just need the tests.

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the test that fails in current master myself. LGTM

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed I'm not able to push changes to your fork's branch. I'm guessing you have disabled this:

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Can you enable it? Alternatively, you can cherry-pick this commit d88b88c

@Lucklyric
Copy link
Contributor Author

Dear @carmocca , it seems the option is already enabled. NVM, I have cherry-picked your revision. Thank you so much.

@carmocca carmocca added the ready PRs ready to be merged label May 21, 2021
@carmocca carmocca removed the ready PRs ready to be merged label May 21, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ethanwharris ethanwharris added the ready PRs ready to be merged label May 24, 2021
@awaelchli awaelchli merged commit 0c958c5 into Lightning-AI:master May 24, 2021
awaelchli added a commit that referenced this pull request May 25, 2021
@Borda Borda mentioned this pull request May 25, 2021
Borda pushed a commit that referenced this pull request May 26, 2021
lexierule pushed a commit that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged tuner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stopped calling datamodule.train_dataloader() when tuning the batch_size using pl.trainer.tune()
5 participants