Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Support time-based checkpointing during training #7515

Merged
merged 11 commits into from
May 19, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented May 13, 2021

What does this PR do?

Fixes #6286

To discuss: The PR currently enforces each trigger (every_n_train_steps, train_time_interval, every_n_val_epochs) to be mutually exclusive. This means if someone wants to checkpoint every N hours and every M train batches, they'd need to create two callbacks.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #7515 (055ec2a) into master (485554c) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7515    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         198     198            
  Lines       12912   12930    +18     
=======================================
- Hits        11912   11368   -544     
- Misses       1000    1562   +562     

@ananthsub ananthsub added this to the v1.4 milestone May 13, 2021
@ananthsub ananthsub added callback checkpointing Related to checkpointing labels May 13, 2021
@ananthsub ananthsub marked this pull request as ready for review May 13, 2021 00:50
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
@ananthsub ananthsub added the ready PRs ready to be merged label May 17, 2021
@ananthsub ananthsub force-pushed the feat-ckpt-time-based-trigger branch from 324687d to 15e6b0a Compare May 18, 2021 06:44
@ananthsub ananthsub enabled auto-merge (squash) May 18, 2021 06:45
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding a note in the case the user wants to do multiple stuff at the same time

.. note:
   If you want a checkpoint at both every N hours and every M train batches or val epochs then multiple ``ModelCheckpoint`` should be created.

@ananthsub ananthsub force-pushed the feat-ckpt-time-based-trigger branch from 15e6b0a to 51ac2ed Compare May 19, 2021 19:56
@mergify mergify bot removed the has conflicts label May 19, 2021
@awaelchli awaelchli enabled auto-merge (squash) May 19, 2021 22:07
@awaelchli awaelchli merged commit 8266b14 into Lightning-AI:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback checkpointing Related to checkpointing ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support time-based checkpointing trigger
6 participants