Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune deprecated trainer attributes #7501

Merged
merged 17 commits into from
May 12, 2021
Merged

Prune deprecated trainer attributes #7501

merged 17 commits into from
May 12, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented May 12, 2021

What does this PR do?

remove deprecated trainer attributes such as use_* or on_*

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label May 12, 2021
@Borda Borda added this to the v1.4 milestone May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #7501 (7cb1816) into master (9698109) will decrease coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7501    +/-   ##
=======================================
- Coverage      92%     92%    -0%     
=======================================
  Files         198     198            
  Lines       12927   12843    -84     
=======================================
- Hits        11945   11823   -122     
- Misses        982    1020    +38     

@Borda Borda marked this pull request as ready for review May 12, 2021 12:29
@Borda Borda requested a review from awaelchli May 12, 2021 14:50
@Borda Borda added the ready PRs ready to be merged label May 12, 2021
@Borda Borda enabled auto-merge (squash) May 12, 2021 14:51
Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more tests need to be cleaned up to reflect the removed properties

@mergify mergify bot removed the has conflicts label May 12, 2021
@Borda Borda requested a review from ananthsub May 12, 2021 19:13
@Borda Borda merged commit d4ec751 into master May 12, 2021
@Borda Borda deleted the prune/trainer-attribs branch May 12, 2021 20:10
@Borda Borda restored the prune/trainer-attribs branch May 12, 2021 20:26
@Borda Borda deleted the prune/trainer-attribs branch May 18, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants