Fix DistribType for ddp_cpu (spawn)
#7492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhdu
requested review from
Borda,
carmocca,
SeanNaren and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7492 +/- ##
=======================================
- Coverage 92% 88% -5%
=======================================
Files 196 196
Lines 12835 12835
=======================================
- Hits 11854 11270 -584
- Misses 981 1565 +584 |
alanhdu
requested review from
awaelchli,
justusschock,
kaushikb11 and
williamFalcon
as code owners
Borda
added
bug
awaelchli
reviewed
May 13, 2021
|
Rebased onto master to fix the failing test. Would it be possible to get another approval + merge this in? This is blocking us from upgrading to Lightning 1.3 (which has several bugfixes that we need). |
awaelchli
changed the title
ddp_cpuddp_cpu (spawn)
kaushikb11
approved these changes
May 14, 2021
|
@alanhdu added a changelog and notified staff for review. |
tchaton
approved these changes
May 14, 2021
Closed
edgarriba
pushed a commit
that referenced
this pull request
May 18, 2021
Borda
pushed a commit
that referenced
this pull request
May 18, 2021
lexierule
pushed a commit
that referenced
this pull request
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7491, assuming that
ddp_cpuis still usingddp_spawnbehind the scenes.