Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DP warning suppression to the DataParallel override #7421

Merged
merged 4 commits into from
May 7, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented May 7, 2021

What does this PR do?

  • Simplifies what's under pytorch_lightning/trainer/
  • Since this is specific to DataParallel, we should include it as part of the plugin definition

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #7421 (ace2fca) into master (fecce50) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7421    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         200     199     -1     
  Lines       12978   12978            
=======================================
- Hits        11942   11354   -588     
- Misses       1036    1624   +588     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning is produced by torch, correct?

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@awaelchli awaelchli merged commit f9e050c into Lightning-AI:master May 7, 2021
@awaelchli awaelchli added this to the v1.4 milestone May 7, 2021
@ananthsub ananthsub changed the title Move DP warning suppression to the DataParallel Plugin Move DP warning suppression to the DataParallel override May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants