Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call super().__init__() in MilestonesFinetuning example #7398

Merged
merged 1 commit into from
May 6, 2021
Merged

Call super().__init__() in MilestonesFinetuning example #7398

merged 1 commit into from
May 6, 2021

Conversation

FlorianMF
Copy link
Contributor

@FlorianMF FlorianMF commented May 6, 2021

What does this PR do?

Fixes #7397

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added bug Something isn't working example labels May 6, 2021
@carmocca carmocca added this to the v1.4 milestone May 6, 2021
@carmocca carmocca added the ready PRs ready to be merged label May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #7398 (0ca0b3c) into master (d52e0a8) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #7398    +/-   ##
=======================================
- Coverage      92%     87%    -4%     
=======================================
  Files         200     200            
  Lines       12982   12982            
=======================================
- Hits        11911   11357   -554     
- Misses       1071    1625   +554     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super gut!

@FlorianMF
Copy link
Contributor Author

@awaelchli danke :)

@carmocca carmocca changed the title add super init to MilestonesFinetuning callback Call super().__init__() in MilestonesFinetuning example May 6, 2021
@kaushikb11 kaushikb11 merged commit d4d959b into Lightning-AI:master May 6, 2021
@Borda Borda modified the milestones: v1.4, v1.3 May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working example ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MilestonesFinetuning in examples is missing super().__init()
6 participants