Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local rank display bug in info message #7395

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented May 6, 2021

What does this PR do?

Fixes a visual bug.
The env variable LOCAL_RANK is not available in all clusters and may be named differently. To resolve this, we will refer to the cluster environment / plugin to determine that value.

Reported in a discussion #7275

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label May 6, 2021
@awaelchli awaelchli added this to the v1.4 milestone May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #7395 (bbacc8d) into master (651f93a) will decrease coverage by 1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7395    +/-   ##
=======================================
- Coverage      92%     91%    -1%     
=======================================
  Files         200     200            
  Lines       12982   13340   +358     
=======================================
+ Hits        11933   12163   +230     
- Misses       1049    1177   +128     

@awaelchli awaelchli marked this pull request as ready for review May 6, 2021 11:57
@justusschock justusschock enabled auto-merge (squash) May 7, 2021 17:44
@awaelchli awaelchli added the ready PRs ready to be merged label May 7, 2021
@awaelchli awaelchli modified the milestones: v1.4, v1.3.x May 8, 2021
@justusschock justusschock merged commit 6bc616d into master May 10, 2021
@justusschock justusschock deleted the bugfix/rank-display branch May 10, 2021 03:26
@carmocca carmocca mentioned this pull request May 10, 2021
Borda pushed a commit that referenced this pull request May 11, 2021
(cherry picked from commit 6bc616d)
Borda pushed a commit that referenced this pull request May 11, 2021
(cherry picked from commit 6bc616d)
Borda pushed a commit that referenced this pull request May 11, 2021
(cherry picked from commit 6bc616d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants