Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependency on pandas, instead use generic csv #736

Merged
merged 6 commits into from
Jan 29, 2020
Merged

Removed dependency on pandas, instead use generic csv #736

merged 6 commits into from
Jan 29, 2020

Conversation

SkafteNicki
Copy link
Member

Before submitting

  • [x ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • [x ] Did you read the contributor guideline?
  • [x ] Did you make sure to update the docs?
  • [x ] Did you write any new necessary tests?

What does this PR do?

Fixes #693
Completely new contributor to this awesome library. Took a stab at this, removing the dependency on pandas since it was only used in 4 files:

  • Includes pandas but does not use it
  • tensorboard.py. Uses pandas for saving csv files. Change to generic csv library
  • lightning.py. Uses pandas for loading csv files. Change to generic csv library
  • memory.py. Uses pandas for 'pretty printing' of model summary. Wrote own formatter that somewhat mimics the output of pandas. Below is the output from running the basic model from the pl_examples folder with the old and new formatting:
    old
    new

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

YES!

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, Thx, just some adjustments needed + rebase

pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
pytorch_lightning/core/lightning.py Outdated Show resolved Hide resolved
pytorch_lightning/core/memory.py Outdated Show resolved Hide resolved
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting for the tests pass...

@Borda
Copy link
Member

Borda commented Jan 26, 2020

seems like an issue with CSV paths, @SkafteNicki can you run the tests locally, pytest

@SkafteNicki
Copy link
Member Author

By accident I had hard coded a path variable, which worked for me locally. It should be fixed now.

@SkafteNicki SkafteNicki requested a review from Borda January 28, 2020 09:05
@williamFalcon
Copy link
Contributor

@SkafteNicki amazing!

@williamFalcon williamFalcon merged commit 9a6838d into Lightning-AI:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop Pandas dependency
3 participants