-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass current_epoch
/global_step
as monitor candidates [1/2]
#7344
Merged
lexierule
merged 4 commits into
master
from
refactor/checkpoint-epoch-step-as-candidates
May 4, 2021
Merged
Pass current_epoch
/global_step
as monitor candidates [1/2]
#7344
lexierule
merged 4 commits into
master
from
refactor/checkpoint-epoch-step-as-candidates
May 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7344 +/- ##
======================================
- Coverage 87% 86% -0%
======================================
Files 200 200
Lines 12922 13017 +95
======================================
+ Hits 11225 11250 +25
- Misses 1697 1767 +70 |
current_epoch
/global_step
as monitor candidatescurrent_epoch
/global_step
as monitor candidates [1/2]
Borda
approved these changes
May 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :]
awaelchli
approved these changes
May 4, 2021
ananthsub
reviewed
May 4, 2021
ananthsub
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor necessary for #6997
Instead of passing these as arguments everywhere, treat them as any other
monitor_candidate
sAlso some non-exhaustive typing in signatures.
Question
Should I deprecate the signature change to
format_checkpoint_name
?Before submitting
PR review