Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass current_epoch/global_step as monitor candidates [1/2] #7344

Merged
merged 4 commits into from
May 4, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented May 4, 2021

What does this PR do?

Refactor necessary for #6997

Instead of passing these as arguments everywhere, treat them as any other monitor_candidates

Also some non-exhaustive typing in signatures.

Question

Should I deprecate the signature change to format_checkpoint_name?

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added refactor checkpointing Related to checkpointing labels May 4, 2021
@carmocca carmocca added this to the v1.3 milestone May 4, 2021
@carmocca carmocca self-assigned this May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #7344 (3520e84) into master (69cf63e) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7344   +/-   ##
======================================
- Coverage      87%     86%   -0%     
======================================
  Files         200     200           
  Lines       12922   13017   +95     
======================================
+ Hits        11225   11250   +25     
- Misses       1697    1767   +70     

@carmocca carmocca changed the title Pass current_epoch/global_step as monitor candidates Pass current_epoch/global_step as monitor candidates [1/2] May 4, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :]

@awaelchli awaelchli requested a review from ananthsub May 4, 2021 14:14
@tchaton tchaton enabled auto-merge (squash) May 4, 2021 17:29
@carmocca carmocca disabled auto-merge May 4, 2021 20:04
@lexierule lexierule merged commit 374ff75 into master May 4, 2021
@lexierule lexierule deleted the refactor/checkpoint-epoch-step-as-candidates branch May 4, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants