-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix auto scaling mode when calling tune method on trainer. #7321
Fix auto scaling mode when calling tune method on trainer. #7321
Conversation
…ferent from `power` or `binsearch` is passed.
Codecov Report
@@ Coverage Diff @@
## master #7321 +/- ##
========================================
- Coverage 87% 81% -7%
========================================
Files 200 200
Lines 12865 14380 +1515
========================================
+ Hits 11210 11588 +378
- Misses 1655 2792 +1137 |
Found the issue. In the Tuner class line 46 we need to insert something like this: if isinstance(self.trainer.auto_scale_batch_size, str):
scale_batch_size_kwargs.setdefault("mode", self.trainer.auto_scale_batch_size) Thanks for adding the breaking test, that's perfect!! |
Co-authored-by: Adrian Wälchli <[email protected]>
Exactly, sorry I broke this recently! Pushed the fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Fixes #7319
Adding a test that should pass if an incorrect mode is used. The test also works to show that passing
binsearch
has no effect on the mode that is being run on the auto scaling. Not sure if the best way would be to update thescale_batch_size_kwargs
in thetune
method of theTrainer
.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃