Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix save_hyperparameters(container) if container is empty #7268

Merged
merged 5 commits into from
Apr 30, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 29, 2021

What does this PR do?

Fixes #7267

Whether this fix is correct remains to be seen ...

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #7268 (bb69009) into master (b670647) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #7268   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files         199     199           
  Lines       12798   12800    +2     
======================================
+ Hits        11679   11681    +2     
  Misses       1119    1119           

@awaelchli awaelchli added this to the v1.3 milestone Apr 29, 2021
@awaelchli awaelchli marked this pull request as ready for review April 29, 2021 20:29
@mergify mergify bot removed the has conflicts label Apr 29, 2021
@awaelchli awaelchli added the ready PRs ready to be merged label Apr 30, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton merged commit 8232de4 into master Apr 30, 2021
@tchaton tchaton deleted the bugfix/save-empty-hparams branch April 30, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support save_hyperparameters(kwargs) with potentially empty kwargs
4 participants