Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Accelerator Connector for Registry #7214

Merged
merged 5 commits into from
May 3, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Update Accelerator Connector for Registry

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added the feature Is an improvement or enhancement label Apr 26, 2021
@kaushikb11 kaushikb11 self-assigned this Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #7214 (42bb790) into master (490cc57) will decrease coverage by 4%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #7214    +/-   ##
=======================================
- Coverage      91%     87%    -4%     
=======================================
  Files         200     200            
  Lines       12857   12866     +9     
=======================================
- Hits        11747   11231   -516     
- Misses       1110    1635   +525     

@SeanNaren SeanNaren added the distributed Generic distributed-related topic label Apr 27, 2021
@kaushikb11 kaushikb11 added the ready PRs ready to be merged label Apr 27, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) April 27, 2021 20:17
@awaelchli awaelchli added this to the v1.3 milestone Apr 30, 2021
Comment on lines +314 to +317
@property
def is_training_type_in_plugins(self) -> bool:
return any(isinstance(plug, str) and plug in TrainingTypePluginsRegistry for plug in self.plugins)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n00b question: could you explain why this iterates over all plugins in the connector? from the naming i'd assume this meant to check if a single plugin instance is contained in the registry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@kaushikb11 kaushikb11 merged commit 6d7c6d6 into Lightning-AI:master May 3, 2021
kaushikb11 added a commit to kaushikb11/pytorch-lightning that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Generic distributed-related topic feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants