-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Accelerator Connector for Registry #7214
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7214 +/- ##
=======================================
- Coverage 91% 87% -4%
=======================================
Files 200 200
Lines 12857 12866 +9
=======================================
- Hits 11747 11231 -516
- Misses 1110 1635 +525 |
@property | ||
def is_training_type_in_plugins(self) -> bool: | ||
return any(isinstance(plug, str) and plug in TrainingTypePluginsRegistry for plug in self.plugins) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n00b question: could you explain why this iterates over all plugins in the connector? from the naming i'd assume this meant to check if a single plugin instance is contained in the registry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup!
What does this PR do?
Update Accelerator Connector for Registry
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃