Deprecate LightningModule.datamodule reference in favor of the trainer one (#6929)
#7168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7168 +/- ##
======================================
Coverage 87% 87%
======================================
Files 200 200
Lines 12894 12895 +1
======================================
+ Hits 11236 11237 +1
Misses 1658 1658 |
|
added the requested test |
awaelchli
requested review from
awaelchli,
Borda,
edenlightning,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
edgarriba
approved these changes
May 3, 2021
carmocca
reviewed
May 3, 2021
carmocca
approved these changes
May 3, 2021
carmocca
reviewed
May 3, 2021
awaelchli
approved these changes
May 3, 2021
kaushikb11
approved these changes
May 3, 2021
carmocca
changed the title
LightningModule.datamodule reference in favor of the trainer one (#6929)
kaushikb11
pushed a commit
to kaushikb11/pytorch-lightning
that referenced
this pull request
May 4, 2021
…ner one (Lightning-AI#6929) (Lightning-AI#7168) Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR attempts to deprecate datamodule and update the documentation accordingly as decided in the GitHub issue
Fixes #6929