-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LightningCLI
documentation and tests
#7156
Improve LightningCLI
documentation and tests
#7156
Conversation
- Added to cli documentation use of subclass help and print_config, submodules and other minor improvements. - Increased minimum jsonargparse version required for new documented features.
Codecov Report
@@ Coverage Diff @@
## master #7156 +/- ##
========================================
- Coverage 92% 83% -8%
========================================
Files 197 198 +1
Lines 12629 13376 +747
========================================
- Hits 11611 11161 -450
- Misses 1018 2215 +1197 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
LightningCLI
documentation and tests
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Hey @mauvilsa, Do we think we should consider create a This would be used to register LightningCLI Example:
From the command line: 1 / Get the store pairs
2 / Filter on the class name
3 / Normal LightningCLI
|
What does this PR do?
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃