-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move save_hyperparameters to its own function #7119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7119 +/- ##
=======================================
- Coverage 92% 92% -0%
=======================================
Files 197 197
Lines 12645 12769 +124
=======================================
+ Hits 11661 11733 +72
- Misses 984 1036 +52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What motivates this change? Just reorganizing?
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
Hey @carmocca, I would like to add Best, |
Co-authored-by: Adrian Wälchli <[email protected]>
What does this PR do?
Motivation
Would like to add
save_hyperparemeters
to Flash Preprocess / Postprocess, so we don't pickle the object.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃