Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix multi-node DDP launch by using local rank instead of global rank for main process #7061

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Apr 16, 2021

What does this PR do?

Fixes #7060

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub added bug Something isn't working distributed Generic distributed-related topic labels Apr 16, 2021
@ananthsub ananthsub added this to the 1.3 milestone Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #7061 (8c2d4ea) into master (832a03a) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #7061    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         196     196            
  Lines       12571   12571            
=======================================
- Hits        11594   10942   -652     
- Misses        977    1629   +652     

@ananthsub ananthsub added the ready PRs ready to be merged label Apr 16, 2021
@ananthsub ananthsub enabled auto-merge (squash) April 16, 2021 16:50
@ananthsub ananthsub merged commit 8bcd169 into Lightning-AI:master Apr 16, 2021
@ananthsub ananthsub deleted the fix-ddp-script branch April 16, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed Generic distributed-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDPPlugin fails for multiple nodes in PL 1.2.8
4 participants