Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MpModelWrapper in TPU Spawn #7045

Merged
merged 12 commits into from
Apr 20, 2021
Merged

Add MpModelWrapper in TPU Spawn #7045

merged 12 commits into from
Apr 20, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Apr 15, 2021

What does this PR do?

Add MpModelWrapper in TPU Spawn.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Apr 15, 2021

Hello @kaushikb11! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-20 12:04:48 UTC

@kaushikb11 kaushikb11 self-assigned this Apr 15, 2021
@kaushikb11 kaushikb11 added this to the 1.2.x milestone Apr 15, 2021
@kaushikb11 kaushikb11 added bug Something isn't working feature Is an improvement or enhancement accelerator: tpu Tensor Processing Unit priority: 0 High priority task labels Apr 15, 2021
@tchaton tchaton enabled auto-merge (squash) April 15, 2021 20:36
@carmocca carmocca disabled auto-merge April 15, 2021 21:47
@kaushikb11 kaushikb11 marked this pull request as draft April 15, 2021 22:22
@kaushikb11
Copy link
Contributor Author

Converted to Draft, as tpu tests were failing.

@Borda Borda modified the milestones: 1.2.x, 1.3 Apr 18, 2021
@@ -257,16 +260,16 @@ def start_predicting(self, trainer) -> None:
xmp.spawn(self.new_process, **self.xmp_spawn_kwargs)

def training_step(self, *args, **kwargs):
return self.lightning_module.training_step(*args, **kwargs)
return self.model(*args, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be wrapped_model.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushikb11 kaushikb11 marked this pull request as ready for review April 20, 2021 12:23
@kaushikb11 kaushikb11 enabled auto-merge (squash) April 20, 2021 12:32
@kaushikb11 kaushikb11 merged commit f168a53 into master Apr 20, 2021
@kaushikb11 kaushikb11 deleted the tpu_spawn_added branch April 20, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit bug Something isn't working feature Is an improvement or enhancement priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants