-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MpModelWrapper in TPU Spawn #7045
Conversation
Hello @kaushikb11! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-20 12:04:48 UTC |
Converted to Draft, as tpu tests were failing. |
@@ -257,16 +260,16 @@ def start_predicting(self, trainer) -> None: | |||
xmp.spawn(self.new_process, **self.xmp_spawn_kwargs) | |||
|
|||
def training_step(self, *args, **kwargs): | |||
return self.lightning_module.training_step(*args, **kwargs) | |||
return self.model(*args, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be wrapped_model
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assigning it while moving the model to device. https://github.com/PyTorchLightning/pytorch-lightning/blob/tpu_spawn_added/pytorch_lightning/plugins/training_type/tpu_spawn.py#L172
MpModelWrapper
is just using mp lock and returns the model https://github.com/pytorch/xla/blob/master/torch_xla/distributed/xla_multiprocessing.py#L432
What does this PR do?
Add MpModelWrapper in TPU Spawn.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃