Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set DistributedSampler seed if seed_everything was called #7024

Merged
merged 12 commits into from
Apr 19, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 14, 2021

What does this PR do?

Fixes #7016

By default our DistributedSampler is initialized with seed 0. This is fine, we need to set a seed there for distributed training because the samples need to be split between the GPUs/nodes. There is however currently no way to customize it unless the user supplies their own DistributedSampler. We can automate that by including the seed from seed_everything, if user calls it.

Note: For everyone that is using seed_everything(x) today, this feature will be affect reproducibility because the seed in the sampler will be set to x instead of 0. If this is undesired, we need to add a flag to seed_everything that can turn this off.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added feature Is an improvement or enhancement bug Something isn't working labels Apr 14, 2021
@awaelchli awaelchli added this to the 1.3 milestone Apr 14, 2021
@awaelchli awaelchli changed the title Feature/sampler seed Seed for DistributedSampler Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #7024 (d18555f) into master (402a258) will decrease coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #7024     +/-   ##
========================================
- Coverage      92%     89%     -3%     
========================================
  Files         194     197      +3     
  Lines       12403   13429   +1026     
========================================
+ Hits        11436   11925    +489     
- Misses        967    1504    +537     

@carmocca carmocca changed the title Seed for DistributedSampler Set DistributedSampler seed if seed_everything was called Apr 15, 2021
@carmocca carmocca enabled auto-merge (squash) April 15, 2021 14:33
@carmocca carmocca added the ready PRs ready to be merged label Apr 15, 2021
@awaelchli awaelchli removed the bug Something isn't working label Apr 18, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca merged commit e9fca76 into master Apr 19, 2021
@carmocca carmocca deleted the feature/sampler-seed branch April 19, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seed for DistributedSampler
4 participants