-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set DistributedSampler
seed if seed_everything
was called
#7024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7024 +/- ##
========================================
- Coverage 92% 89% -3%
========================================
Files 194 197 +3
Lines 12403 13429 +1026
========================================
+ Hits 11436 11925 +489
- Misses 967 1504 +537 |
carmocca
approved these changes
Apr 15, 2021
DistributedSampler
seed if seed_everything
was called
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca
approved these changes
Apr 15, 2021
s-rog
approved these changes
Apr 19, 2021
tchaton
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #7016
By default our DistributedSampler is initialized with seed 0. This is fine, we need to set a seed there for distributed training because the samples need to be split between the GPUs/nodes. There is however currently no way to customize it unless the user supplies their own DistributedSampler. We can automate that by including the seed from
seed_everything
, if user calls it.Note: For everyone that is using
seed_everything(x)
today, this feature will be affect reproducibility because the seed in the sampler will be set to x instead of 0. If this is undesired, we need to add a flag toseed_everything
that can turn this off.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃