-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PickleError base class to detect all pickle errors #6917
Use PickleError base class to detect all pickle errors #6917
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6917 +/- ##
=======================================
- Coverage 92% 87% -5%
=======================================
Files 194 194
Lines 12419 12419
=======================================
- Hits 11419 10771 -648
- Misses 1000 1648 +648 |
Could you also add a test under tests/utilities/test_parsing.py in the test called "test_is_picklable" with your object that wasn't picklable? |
How does that look? My model has PyTorch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, thanks for the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition !
What does this PR do?
Fixes #6902
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
First PR!