Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PickleError base class to detect all pickle errors #6917

Merged
merged 6 commits into from
Apr 14, 2021
Merged

Use PickleError base class to detect all pickle errors #6917

merged 6 commits into from
Apr 14, 2021

Conversation

SpontaneousDuck
Copy link
Contributor

@SpontaneousDuck SpontaneousDuck commented Apr 9, 2021

What does this PR do?

Fixes #6902

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

First PR!

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #6917 (d266c36) into master (03a73b3) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6917    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         194     194            
  Lines       12419   12419            
=======================================
- Hits        11419   10771   -648     
- Misses       1000    1648   +648     

@awaelchli
Copy link
Contributor

Could you also add a test under tests/utilities/test_parsing.py in the test called "test_is_picklable" with your object that wasn't picklable?

@SpontaneousDuck
Copy link
Contributor Author

How does that look? My model has PyTorch ScriptModule in it so I added an empty ScriptModule to the test. I verified this throws the same error I am receiving in #6902 .

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks for the fix

@awaelchli awaelchli added ready PRs ready to be merged bug Something isn't working labels Apr 9, 2021
@awaelchli awaelchli added this to the 1.2.x milestone Apr 9, 2021
@mergify mergify bot removed the has conflicts label Apr 12, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition !

@tchaton tchaton enabled auto-merge (squash) April 14, 2021 08:46
@tchaton tchaton merged commit dcff503 into Lightning-AI:master Apr 14, 2021
@SpontaneousDuck SpontaneousDuck deleted the bugfix/6902_PickleError branch April 28, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pickle Error in clean_namespace
5 participants