-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPUSpawn + IterableDataset error message #6875
Merged
kaushikb11
merged 9 commits into
Lightning-AI:master
from
ethanwharris:tpu_iterabledataset_error_msg
Apr 8, 2021
Merged
TPUSpawn + IterableDataset error message #6875
kaushikb11
merged 9 commits into
Lightning-AI:master
from
ethanwharris:tpu_iterabledataset_error_msg
Apr 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
requested review from
awaelchli,
justusschock,
SeanNaren and
tchaton
as code owners
April 7, 2021 20:01
tchaton
approved these changes
Apr 8, 2021
@tchaton Thanks for the review 😃 I've added an earlier message when the dataloaders are passed to fit and some tests, mind re-reviewing? |
ethanwharris
requested review from
Borda,
carmocca and
williamFalcon
as code owners
April 8, 2021 08:35
kaushikb11
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
awaelchli
approved these changes
Apr 8, 2021
awaelchli
added
bug
Something isn't working
accelerator: tpu
Tensor Processing Unit
labels
Apr 8, 2021
carmocca
reviewed
Apr 8, 2021
carmocca
reviewed
Apr 8, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
carmocca
reviewed
Apr 8, 2021
carmocca
approved these changes
Apr 8, 2021
Closed
SeanNaren
pushed a commit
that referenced
this pull request
Apr 13, 2021
Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit 1c2ecbf)
lexierule
pushed a commit
that referenced
this pull request
Apr 14, 2021
Co-authored-by: Carlos Mocholí <[email protected]> (cherry picked from commit 1c2ecbf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a more firendly error message when using iterable dataset + TPUSpawn (currently this fails inside torch XLA here: https://github.com/pytorch/xla/blob/86463f894eb21f31dcd3449e4e55cc45b8a8586a/torch_xla/distributed/parallel_loader.py#L89)
See example outputs here: https://colab.research.google.com/drive/1fXtIfIemyzuF2Flxvyjd0aHz6zL8u5AE?usp=sharing
Would be nice if this could happen on just one rank (perhaps switching to rank_zero_warn?), can't happen pre-accelerator as needs the dataloaders to actually exist
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃