-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match the number of outputs of backward with forward for AllGatherGrad #6625
Conversation
…d for AllGatherGrad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch !
@ArvinZhuang nice, can you also add a test to catch this issue later, I would say that the example from issue shall be fine :] |
Hi @Borda, I have added a test that raises the error before the fix and passes after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix
@@ -95,3 +95,26 @@ def training_epoch_end(self, outputs) -> None: | |||
|
|||
trainer.fit(model) | |||
assert model.training_epoch_end_called | |||
|
|||
|
|||
@RunIf(min_gpus=2, skip_windows=True, special=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't run
we need to add add it to tests/special_tests.sh
special=True
means this test gets skipped by default
and skip_windows
would be redundant in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I noticed this, I actually commented out special=True
when I test this. I put it here just because I was following the same settings of other tests in this script.
What does this PR do?
Fixes #6624
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃