-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeepSpeed ZeRO Update #6546
Merged
Merged
DeepSpeed ZeRO Update #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @tchaton! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-30 16:19:26 UTC |
Codecov Report
@@ Coverage Diff @@
## master #6546 +/- ##
=======================================
- Coverage 91% 86% -6%
=======================================
Files 192 192
Lines 12231 12494 +263
=======================================
- Hits 11184 10710 -474
- Misses 1047 1784 +737 |
SeanNaren
reviewed
Mar 30, 2021
SeanNaren
reviewed
Mar 30, 2021
SeanNaren
reviewed
Mar 30, 2021
SeanNaren
approved these changes
Mar 30, 2021
justusschock
approved these changes
Mar 30, 2021
carmocca
approved these changes
Mar 30, 2021
Borda
reviewed
Mar 30, 2021
Borda
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds DeepSpeed ZeRO 3 to the DeepSpeed plugin. Due to the nature of the plugin, we've had to make a few changes summarized below.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃