-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Train loop config validation was run during trainer.predict
#6541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you want to also open a PR to master with these changes and resolve this TODO
?
@carmocca Sure. Wondering where should I do the Changelog update here. |
in Added section :] |
trainer.predict
Hello @kaushikb11! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-16 16:19:18 UTC |
@Borda Your commit won't work. |
it shall be defined in the parameter, right? |
what is the difference to #6543? |
What does this PR do?
Fixes:
While predicting, it was verifying the train_loop configuration.
Only necessary for the bug-fix release branch
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃