Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Train loop config validation was run during trainer.predict #6541

Merged
merged 7 commits into from
Mar 16, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Mar 15, 2021

What does this PR do?

Fixes:
While predicting, it was verifying the train_loop configuration.

Only necessary for the bug-fix release branch

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added this to the 1.2.x milestone Mar 15, 2021
@kaushikb11 kaushikb11 added the priority: 0 High priority task label Mar 15, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushikb11
Copy link
Contributor Author

@carmocca Sure.

Wondering where should I do the Changelog update here.

tests/trainer/test_trainer.py Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Mar 15, 2021

Wondering where should I do the Changelog update here.

in Added section :]

@kaushikb11 kaushikb11 changed the title Add verify config for predict Fix: Train loop config validation was run during trainer.predict Mar 16, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 16, 2021

Hello @kaushikb11! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-16 16:19:18 UTC

@kaushikb11
Copy link
Contributor Author

@Borda Your commit won't work. dataloaders is not defined. Reverting back.

@kaushikb11 kaushikb11 self-assigned this Mar 16, 2021
@Borda
Copy link
Member

Borda commented Mar 16, 2021

@Borda Your commit won't work. dataloaders is not defined. Reverting back.

it shall be defined in the parameter, right?

@Borda
Copy link
Member

Borda commented Mar 16, 2021

what is the difference to #6543?

@kaushikb11 kaushikb11 changed the base branch from release/1.2.x to v1.2.4 March 16, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants