Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix self.device access in DataParallel #6414

Merged
merged 10 commits into from
Apr 13, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Mar 8, 2021

What does this PR do?

DataParallel does not maintain state during the forward on the replicas. Therefore, self.device in e.g. training_step points to the root device no matter on which gpu.
We can fix this problem by taking the device from the input tensors, these are guaranteed to be on the right device.

The only exception is when the model doesn't get a batch with tensors in it. This is rare, and the best we can do is warn the user that self.device will not work.

Fixes #6413
Fixes #6563

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added bug Something isn't working strategy: dp (removed in pl) DataParallel labels Mar 8, 2021
@awaelchli awaelchli added this to the 1.2.x milestone Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #6414 (5bd3db0) into master (b46cc55) will decrease coverage by 5%.
The diff coverage is 80%.

@@           Coverage Diff           @@
##           master   #6414    +/-   ##
=======================================
- Coverage      92%     87%    -5%     
=======================================
  Files         194     194            
  Lines       12355   12365    +10     
=======================================
- Hits        11339   10696   -643     
- Misses       1016    1669   +653     

@awaelchli awaelchli marked this pull request as ready for review April 11, 2021 03:58
@awaelchli awaelchli force-pushed the bugfix/dp-self-device branch from 53378ca to f4281c0 Compare April 11, 2021 04:12
@awaelchli awaelchli added the ready PRs ready to be merged label Apr 12, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really Neat !

@awaelchli awaelchli merged commit 80c5293 into master Apr 13, 2021
@awaelchli awaelchli deleted the bugfix/dp-self-device branch April 13, 2021 00:03
@SeanNaren SeanNaren mentioned this pull request Apr 13, 2021
SeanNaren pushed a commit that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged strategy: dp (removed in pl) DataParallel
Projects
None yet
5 participants