-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make move_metrics_to_cpu work recursively #6007
Merged
Borda
merged 6 commits into
Lightning-AI:master
from
ddrevicky:5381/move-metrics-to-cpu-works-nonrecursively
Feb 16, 2021
Merged
Make move_metrics_to_cpu work recursively #6007
Borda
merged 6 commits into
Lightning-AI:master
from
ddrevicky:5381/move-metrics-to-cpu-works-nonrecursively
Feb 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
approved these changes
Feb 16, 2021
Codecov Report
@@ Coverage Diff @@
## master #6007 +/- ##
=======================================
- Coverage 93% 90% -3%
=======================================
Files 159 159
Lines 11209 11080 -129
=======================================
- Hits 10440 10007 -433
- Misses 769 1073 +304 |
carmocca
reviewed
Feb 16, 2021
Borda
approved these changes
Feb 16, 2021
@ddrevicky mind rebase/merge master regarding updated TPU configuration... 🐰 |
tchaton
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Great catch !
55cf42c
to
ff77f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
to_cpu
flag down the call chain inrecursive_detach
Fixes #5831
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃