Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make move_metrics_to_cpu work recursively #6007

Conversation

ddrevicky
Copy link
Contributor

@ddrevicky ddrevicky commented Feb 16, 2021

What does this PR do?

  • Passes the to_cpu flag down the call chain in recursive_detach

Fixes #5831

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added the bug Something isn't working label Feb 16, 2021
@carmocca carmocca assigned carmocca and unassigned carmocca Feb 16, 2021
@carmocca carmocca added this to the 1.2.x milestone Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #6007 (a3fb718) into master (6d1e055) will decrease coverage by 3%.
The diff coverage is 70%.

@@           Coverage Diff           @@
##           master   #6007    +/-   ##
=======================================
- Coverage      93%     90%    -3%     
=======================================
  Files         159     159            
  Lines       11209   11080   -129     
=======================================
- Hits        10440   10007   -433     
- Misses        769    1073   +304     

@Borda Borda added the ready PRs ready to be merged label Feb 16, 2021
@Borda Borda enabled auto-merge (squash) February 16, 2021 16:06
@Borda
Copy link
Member

Borda commented Feb 16, 2021

@ddrevicky mind rebase/merge master regarding updated TPU configuration... 🐰

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Great catch !

@Borda Borda force-pushed the 5381/move-metrics-to-cpu-works-nonrecursively branch from 55cf42c to ff77f0b Compare February 16, 2021 21:11
@Borda Borda merged commit c9fde04 into Lightning-AI:master Feb 16, 2021
@Borda Borda modified the milestones: 1.2.x, 1.2 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move_metrics_to_cpu works non-recursively
4 participants