Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Add on_epoch_end hook after on_test/validation_epoch_end hook #5986

Merged
merged 10 commits into from
Feb 17, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 15, 2021

What does this PR do?

This PR add missing on_epoch_end hook after validation / test epoch.

Fixes #5917

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Feb 15, 2021
@tchaton tchaton added this to the 1.2 milestone Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #5986 (9f9ad34) into master (f655f97) will increase coverage by 2%.
The diff coverage is 98%.

@@           Coverage Diff           @@
##           master   #5986    +/-   ##
=======================================
+ Coverage      91%     93%    +2%     
=======================================
  Files         160     160            
  Lines       11313   11341    +28     
=======================================
+ Hits        10272   10523   +251     
+ Misses       1041     818   -223     

@tchaton tchaton added the bug Something isn't working label Feb 15, 2021
@Borda Borda marked this pull request as draft February 15, 2021 22:43
@tchaton tchaton marked this pull request as ready for review February 16, 2021 18:37
@tchaton tchaton enabled auto-merge (squash) February 16, 2021 22:08
@mergify mergify bot removed the has conflicts label Feb 17, 2021
@tchaton tchaton merged commit 443ccf1 into master Feb 17, 2021
@tchaton tchaton deleted the bugfix/5917_on_epoch_end branch February 17, 2021 17:21
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like there is on_test_epoch_end but no on_train_epoch_end
edit: no it's there 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour of hooking inside callback
5 participants