Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add TORCH_DISTRIBUTED_BACKEND env variable #5981

Merged
merged 10 commits into from
Feb 17, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 15, 2021

What does this PR do?

This PR expose torch backend as an env variable for the user.

 PL_TORCH_DISTRIBUTED_BACKEND=gloo python train.py ...

Fixes #5355

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added distributed Generic distributed-related topic design Includes a design discussion labels Feb 15, 2021
@tchaton tchaton added this to the 1.2 milestone Feb 15, 2021
@tchaton tchaton self-assigned this Feb 15, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 15, 2021

Hello @tchaton! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-17 16:10:55 UTC

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #5981 (cd8de8f) into master (5157ba5) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5981   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         160     160           
  Lines       11340   11340           
======================================
- Hits        10550   10521   -29     
- Misses        790     819   +29     

@mergify mergify bot removed the has conflicts label Feb 17, 2021
@tchaton tchaton enabled auto-merge (squash) February 17, 2021 15:25
@tchaton tchaton merged commit 5700fd0 into master Feb 17, 2021
@tchaton tchaton deleted the bugfix/5355_expose_torch_backend branch February 17, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion distributed Generic distributed-related topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning does not support DDP with Sparse Gradients
6 participants