Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Repeated .fit() calls ignore max_steps iteration bound #5936

Merged
merged 7 commits into from
Feb 13, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Fixes #4809

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #5936 (5965b9b) into master (b8619a6) will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #5936    +/-   ##
=======================================
- Coverage      84%     82%    -2%     
=======================================
  Files         184     184            
  Lines       13306   13307     +1     
=======================================
- Hits        11137   10863   -274     
- Misses       2169    2444   +275     

@kaushikb11 kaushikb11 marked this pull request as draft February 12, 2021 11:50
@kaushikb11 kaushikb11 marked this pull request as ready for review February 12, 2021 13:00
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Borda Borda enabled auto-merge (squash) February 12, 2021 20:31
@Borda Borda added the bug Something isn't working label Feb 12, 2021
@Borda Borda added this to the 1.2 milestone Feb 12, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 13, 2021

Hello @kaushikb11! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-13 07:10:25 UTC

@mergify mergify bot removed the has conflicts label Feb 13, 2021
@Borda Borda merged commit 42dc5d2 into Lightning-AI:master Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated .fit() calls ignore max_steps iteration bound
5 participants