Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor utilities/imports.py #5874

Merged
merged 10 commits into from
Feb 10, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Feb 9, 2021

What does this PR do?

Minor clean-up and sorted _*_AVAILABLE variables

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

@pep8speaks
Copy link

pep8speaks commented Feb 9, 2021

Hello @carmocca! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-10 15:07:10 UTC

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #5874 (e3114ce) into release/1.2-dev (a028171) will decrease coverage by 5%.
The diff coverage is 94%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5874    +/-   ##
================================================
- Coverage               88%     83%    -5%     
================================================
  Files                  181     181            
  Lines                12964   12964            
================================================
- Hits                 11462   10780   -682     
- Misses                1502    2184   +682     

@carmocca carmocca added ready PRs ready to be merged refactor labels Feb 9, 2021
@Borda Borda removed the ready PRs ready to be merged label Feb 9, 2021
pytorch_lightning/utilities/imports.py Outdated Show resolved Hide resolved
pytorch_lightning/utilities/imports.py Show resolved Hide resolved
@Borda Borda added the ready PRs ready to be merged label Feb 10, 2021
@mergify mergify bot requested a review from a team February 10, 2021 09:47
pytorch_lightning/utilities/imports.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team February 10, 2021 10:15
@Borda Borda force-pushed the refactor-module-available branch from 2df3538 to 9e1067d Compare February 10, 2021 10:17
@mergify mergify bot removed the has conflicts label Feb 10, 2021
@carmocca carmocca merged commit ecd3678 into release/1.2-dev Feb 10, 2021
@carmocca carmocca deleted the refactor-module-available branch February 10, 2021 23:32
@Borda Borda mentioned this pull request Feb 10, 2021
12 tasks
@carmocca carmocca self-assigned this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants