-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PredictLoop #5752
Add PredictLoop #5752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice and I like the description of the trainer flow, this should definitely make its way to the docs for users if possible!
Thanks. I was thinking to make a cleaner for the documentation. Best, |
What does this PR do?
This PR adds PredictLoop.
Currently the
trainer.predict
was using EvaluationLoop with trainer.testing.Now, it uses its own loop and remove the EvaluationLoop dependency to predict.
Fixes #5475
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃