Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugOnFeat] Resolve bug with Finetuning #5744

Merged
merged 13 commits into from
Feb 4, 2021
Merged

[BugOnFeat] Resolve bug with Finetuning #5744

merged 13 commits into from
Feb 4, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Feb 2, 2021 •
edited
Loading

What does this PR do?

The BaseFinetuning Callback contained bugs within its freeze and unfreeze_and_add_param_group functions.

This PR resolves those bugs and add missing tests for those functions.

Furthermore, it renames the callbacks following Callback convention.

Fixes # (issue) <- this links related issue to this PR

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Feb 2, 2021
@tchaton tchaton added this to the 1.2 milestone Feb 2, 2021
@tchaton tchaton added the bug Something isn't working label Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021 •
edited
Loading

Codecov Report

Merging #5744 (44cc9f7) into release/1.2-dev (9064b83) will increase coverage by 50%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##           release/1.2-dev   #5744     +/-   ##
=================================================
+ Coverage               31%     82%    +50%     
=================================================
  Files                  181     181             
  Lines                12694   14015   +1321     
=================================================
+ Hits                  3990   11448   +7458     
+ Misses                8704    2567   -6137

@tchaton tchaton marked this pull request as ready for review February 2, 2021 11:02
@Borda Borda added the feature Is an improvement or enhancement label Feb 3, 2021
rohitgr7
rohitgr7 reviewed Feb 3, 2021
View reviewed changes
@s-rog
Copy link
Contributor

s-rog commented Feb 4, 2021

btw we also got #5643

SkafteNicki
SkafteNicki reviewed Feb 4, 2021
View reviewed changes
SkafteNicki
SkafteNicki approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]

Borda
Borda approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@Borda Borda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactoring but not sure what bug it solves...

EDIT: bug description was added, thx :]

rohitgr7
rohitgr7 reviewed Feb 4, 2021
View reviewed changes
carmocca
carmocca reviewed Feb 4, 2021
View reviewed changes
@tchaton tchaton added the ready PRs ready to be merged label Feb 4, 2021
rohitgr7
rohitgr7 approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just few more comments.

@carmocca carmocca mentioned this pull request Feb 4, 2021
Merged
13 tasks
@tchaton tchaton merged commit e425bf3 into release/1.2-dev Feb 4, 2021
@tchaton tchaton deleted the debug_finetuning branch February 4, 2021 18:36
@carmocca carmocca mentioned this pull request Feb 4, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-rog s-rog s-rog left review comments

@Borda Borda Borda approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@carmocca carmocca carmocca approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
bug Something isn't working feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.2
Development

Successfully merging this pull request may close these issues.
7 participants
@tchaton @s-rog @Borda @SeanNaren @carmocca @SkafteNicki @rohitgr7