Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor access to trainer attributes in LightningModule #5730

Merged
merged 12 commits into from
Feb 1, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Feb 1, 2021

What does this PR do?

Implements read-only passthrough for the attributes that are exclusively handled by the Trainer. This avoids accidental divergence of state. Additionally, just to be safe we make the trainer a week-ref.

Refactor is also partially necessary for #5616

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added this to the 1.2 milestone Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #5730 (6ef068a) into release/1.2-dev (069ae27) will decrease coverage by 2%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5730    +/-   ##
================================================
- Coverage               89%     87%    -2%     
================================================
  Files                  173     173            
  Lines                12495   12758   +263     
================================================
- Hits                 11171   11089    -82     
- Misses                1324    1669   +345     

tests/core/test_lightning_module.py Show resolved Hide resolved
@Borda Borda added the ready PRs ready to be merged label Feb 1, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tchaton tchaton enabled auto-merge (squash) February 1, 2021 11:29
@tchaton tchaton merged commit 344f3a9 into release/1.2-dev Feb 1, 2021
@tchaton tchaton deleted the ref/ranks branch February 1, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants