Disable training with zero num_training_batches when insufficient limit_train_batches #5703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikb11
requested review from
awaelchli,
Borda,
carmocca,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
|
Hello @kaushikb11! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-02 17:06:55 UTC |
rohitgr7
reviewed
Jan 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #5703 +/- ##
======================================
- Coverage 90% 89% -0%
======================================
Files 134 134
Lines 10057 10053 -4
======================================
- Hits 9010 8982 -28
- Misses 1047 1071 +24 |
SeanNaren
reviewed
Jan 31, 2021
carmocca
reviewed
Feb 1, 2021
carmocca
reviewed
Feb 1, 2021
carmocca
reviewed
Feb 1, 2021
carmocca
approved these changes
Feb 1, 2021
SeanNaren
approved these changes
Feb 1, 2021
Borda
reviewed
Feb 2, 2021
tchaton
pushed a commit
that referenced
this pull request
Feb 5, 2021
…it_train_batches (#5703) * disable training when zero num_train_batches with limit_train_batches * refactor train skip condition * fix formatting issues * fix formatting issues * ref: test error msg * fix tests for data loader calls * fix train dataloader condition * update limit_train_batches upper range in test comment * remove model state check test Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda
pushed a commit
that referenced
this pull request
Feb 5, 2021
…it_train_batches (#5703) * disable training when zero num_train_batches with limit_train_batches * refactor train skip condition * fix formatting issues * fix formatting issues * ref: test error msg * fix tests for data loader calls * fix train dataloader condition * update limit_train_batches upper range in test comment * remove model state check test Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Borda
pushed a commit
that referenced
this pull request
Feb 5, 2021
…it_train_batches (#5703) * disable training when zero num_train_batches with limit_train_batches * refactor train skip condition * fix formatting issues * fix formatting issues * ref: test error msg * fix tests for data loader calls * fix train dataloader condition * update limit_train_batches upper range in test comment * remove model state check test Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Training should be disabled when
limit_train_batchesis float, andnum_training_batches == int(num_training_batches * limit_train_batches) == 0, this would be lead to zeronum_training_batches. But the Training wasn't being skipped, while still doing 1 step per epoch. This PR addresses the issue.Fixes #5029
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃