Remove unnecessary intermediate layers in base-conda Dockerfile #5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5697 +/- ##
======================================
Coverage 93% 93%
======================================
Files 134 134
Lines 10055 10055
======================================
Hits 9388 9388
Misses 667 667 |
Borda
previously approved these changes
Jan 28, 2021
|
seems that all docker builds are failing now... :/ |
@Borda it should be better now! |
Borda
approved these changes
Jan 29, 2021
sumanthratna
requested review from
awaelchli,
carmocca,
justusschock,
SeanNaren and
williamFalcon
as code owners
awaelchli
approved these changes
Jan 29, 2021
rohitgr7
approved these changes
Jan 29, 2021
SkafteNicki
approved these changes
Jan 29, 2021
|
I wonder why isn't it merged automatically. |
hard to tell you now when it is merged :P |
tchaton
pushed a commit
that referenced
this pull request
Feb 5, 2021
* [docker][base-conda] Combine ENV+COPY instructions * [docker][base-cuda] Combine ENV+COPY instructions * [docker][base-xla] Combine ENV+COPY instructions * [docker][base-cuda] Fix COPY instruction * [docker][base-xla] Fix quote in ENV * [docker][base-xla] Fix $PATH in ENV * [docker][base-conda] Fix COPY instruction * chlog Co-authored-by: Jirka Borovec <[email protected]>
Borda
added a commit
that referenced
this pull request
Feb 5, 2021
* [docker][base-conda] Combine ENV+COPY instructions * [docker][base-cuda] Combine ENV+COPY instructions * [docker][base-xla] Combine ENV+COPY instructions * [docker][base-cuda] Fix COPY instruction * [docker][base-xla] Fix quote in ENV * [docker][base-xla] Fix $PATH in ENV * [docker][base-conda] Fix COPY instruction * chlog Co-authored-by: Jirka Borovec <[email protected]>
Borda
added a commit
that referenced
this pull request
Feb 5, 2021
* [docker][base-conda] Combine ENV+COPY instructions * [docker][base-cuda] Combine ENV+COPY instructions * [docker][base-xla] Combine ENV+COPY instructions * [docker][base-cuda] Fix COPY instruction * [docker][base-xla] Fix quote in ENV * [docker][base-xla] Fix $PATH in ENV * [docker][base-conda] Fix COPY instruction * chlog Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
before this PR, the base-conda Dockerfile created 12 unnecessary intermediate layers (mostly from ENVs). If you all decide to merge this PR, I can create PRs for the other Dockerfiles (or I can fix the other Dockerfiles in this PR).
Please let me know if this is worth updating the changelog!
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃